Visors can be tricky to do. The ODST visors are especially difficult because of their unique geometry. It looks like you have made your visor by cutting and reattaching pieces of an already existing visor, but the effect isn't quite complete because of the noticeable seams. There's a few things you try:
Personally, I am a fan of the look of vacuum formed visors. If you want to see how I do my visors, I have a tutorial here on the 405th:
It seems that the 405th is in need of a visor dying and chroming tutorial so I shall volunteer be the first to step up to the plate! In this tutorial we will be covering how I dye my visors any particular colour, and how I use spray chrome to block others from seeing my face while allowing me...
www.405th.com
If you don't want to go through the trouble of vacuum forming a visor, there are other visor methods in the tutorial section that are worth checking out:
Tutorial Index Who can make a Tutorial? A: Anyone How do I make a tutorial? A: Create a thread in any part of the forum you think your tutorial pertains to such as Costume, Props, Soft Parts etc. How do I get the tutorial in the Tutorial Section? A: start a conversation with me...
www.405th.com